9 replies to this topic

[baggyn]

hi

im trying to code a page so that a random number is selected, if one number is selected it displays one thing, if the other number is selected it displays something else.

I wrote this but it doesnt seem to work can anyone help?

<?php
$arg = rand(1,2);

if ($arg='1')
echo "lo";

if ($arg='2')
echo "hi";
?>

[rc69]

Vary simple problem...

if($arg==1){
  echo "lo";
}elseif($arg==2){
  echo "hi";
}

When doing an if, you want to see if something equals "==" another thing. Not set it equal "=" to another.

p.s. I did change the structure of your code to how i prefer it, you can change it to the way you had it (if you know how) later

[HaloprO]

<?php
$arg = rand(1, 2);
$output = array(
'lo',
'hi');
echo $output[$arg-1];
?>

This is a little shorter, and does the same thing

[MillerTime]

rc69, on Sep 28 2005, 10:35 PM, said:

Vary simple problem...

if($arg==1){
  echo "lo";
}elseif($arg==2){
  echo "hi";
}

When doing an if, you want to see if something equals "==" another thing. Not set it equal "=" to another.

p.s. I did change the structure of your code to how i prefer it, you can change it to the way you had it (if you know how) later

actually, "==" is not called "equal" it is called "identical". So when using ifs and elses do not use the equal sign ("=") because that would just cause an infinite loop

[rc69]

Well, if you're going to be just echoing a string, yes, halopro's code would probably be better, although it may use more memory (not even a noticeable amount). If you're going to preform an actual function or something, you'd use something like mine

MillerTime, on Sep 29 2005, 03:25 PM, said:

rc69, on Sep 28 2005, 10:35 PM, said:

Vary simple problem...

if($arg==1){
  echo "lo";
}elseif($arg==2){
  echo "hi";
}

When doing an if, you want to see if something equals "==" another thing.  Not set it equal "=" to another.

p.s.  I did change the structure of your code to how i prefer it, you can change it to the way you had it (if you know how) later

actually, "==" is not called "equal" it is called "identical". So when using ifs and elses do not use the equal sign ("=") because that would just cause an infinite loop

http://www.php.net/manual/en/language.oper....comparison.php
"===" is 'identical'. Trust me, i've been doing this for a while, and they told me i was right ^

[Hayden]

HaloprO, on Sep 29 2005, 06:11 AM, said:

<?php
$arg = rand(1, 2);
$output = array(
'lo',
'hi');
echo $output[$arg-1];
?>

This is a little shorter, and does the same thing

should actually be

$arg = rand(0, 1);

right?

because array[0] = "lo", array[1]="hi" and array[2]=""

Edited by SpaceGhost, 07 October 2005 - 04:54 PM.

[HaloprO]

Yes it should SpaceGhost, that's why in mine I used -1 at the end, and for you guys discussing == and ===, == is for stuff likw equal to, with exceptions (ie: gHoSt = GHOST) and for === it would have to be GHOST = GHOST, case sensitive really :/

[Hayden]

well, if that's the difference then why not just do?

strtolower("GHOST") == strtolower("gHoST");

[HaloprO]

Because that is like 15 chars longer

[rc69]

http://www.php.net/m...comparisons.php The actual reference from php.net
If you want to know more, or argue who's right, go there...

I'm closing this topic since it's already been solved. Or at least is presumed solved.