42 replies to this topic

[donkeymusic]

Hello i have never tried to create a form on a site so this is my first attempt.

www.retrodesigner.co.uk/contact.html

i selected the fields and set it up following a guide but when i click n the send button it just opne my mail client and none of the data inputted is there. not sure where i have gone wrong

and is there anway improve the look of he boxes and line them up?

any help would be great thanks

[rc69]

Since it has a mailto: action, all it will do is open your e-mail client, and add the attributes to the message body of the e-mail. The rest of the info has to be filled out by hand, or you can use the onSubmit attribute of the form to modify the action so it auto-fills out some of the fields for you. Look in the JavaScript section of the tutorial database, i believe there's something in there about this.

Although, the easiest way to handle contact forms is through a server-side language like PHP, which i would recommend looking into (i know there are a ton of tutorials on how to do it in the database).

And i know i'm going to get yelled at for this, but the easiest way to organize a form is with a table.

Edited by rc69, 21 December 2005 - 01:51 PM.

[donkeymusic]

Hi dan

Thanks for the help, i have just got round to trying that and it works, just a few questions though, hope you or someone can help me.

1-when the send button is pressed i get a message saying it has been sent bu this just opens on a blank page with the text and then there is no option to go back to the site, is it possible to have the message go to a page of the site?

2- in the PHP file there is an option for if there is an error but when tested i can leave some section of the form empty and it still sends, so theerror message does not work, is it possible to set the form up so that if a section is not completed that the form will not send?

any help would be great, thanks

[Av-]

1. You can easily change that by adding your own html or redirecting the users to another page with the header function.
if you want to redirect them replace this

echo "Your form was succsessful, write what you want here";

with this

header('location: succespage.php');

====
2. The form is send no matter what, because there is simply NO error checking.

[donkeymusic]

Avalanche, on Jan 3 2006, 02:05 PM, said:

1. You can easily change that by adding your own html or redirecting the users to another page with the header function.
if you want to redirect them replace this

echo "Your form was succsessful, write what you want here";

with this

header('location: succespage.php');

====
2. The form is send no matter what, because there is simply NO error checking.

Thanks avalanche,

ihave just had a look at that,

i changed my line to

header('location: aboutrd.html');

but i still seem to load up the original page, this can be viewed at http://www.retrodesi...uk/contact.html

[Av-]

You sure you uploaded your files, because 'aboutrd.html' doesnt seem to be there either

[donkeymusic]

Avalanche, on Jan 3 2006, 02:05 PM, said:

1. You can easily change that by adding your own html or redirecting the users to another page with the header function.
if you want to redirect them replace this

echo "Your form was succsessful, write what you want here";

with this

header('location: succespage.php');

====
2. The form is send no matter what, because there is simply NO error checking.

How do i add error checking? thanks

[Av-]

this should work...

<? 

$name=$_POST['name']; 

$email=$_POST['email']; 

$comment=$_POST['comment']; 

$to="Write you email address here, it will not be visible"; 

$message=" $name sent you a comment on your site.\n They said $story\n\n Their e-mail address was: $email"; 

if(!empty($name) || !empty($email) || !empty($comment)){

	if(mail($to,"Comments From Your Site",$message,"From: $email\n")) { 

	echo "Your form was succsessful, write what you want here"; 
}
} else { 

echo "PLEASE FILL IN ALL FIELDS!!!!!!."; 

} 

?>

edit: fixed a parse error

Edited by Avalanche, 04 January 2006 - 09:58 AM.

[donkeymusic]

Avalanche, on Jan 4 2006, 02:58 PM, said:

this should work...

<? 

$name=$_POST['name']; 

$email=$_POST['email']; 

$comment=$_POST['comment']; 

$to="Write you email address here, it will not be visible"; 

$message=" $name sent you a comment on your site.\n They said $story\n\n Their e-mail address was: $email"; 

if(!empty($name) || !empty($email) || !empty($comment)){

	if(mail($to,"Comments From Your Site",$message,"From: $email\n")) { 

	echo "Your form was succsessful, write what you want here"; 
}
} else { 

echo "PLEASE FILL IN ALL FIELDS!!!!!!."; 

} 

?>

edit: fixed a parse error

is that that i need to add the last echo command?

whats a parse error?

thanks

[Av-]

this is what i added, it has nothing to do with the last echo command, i should've left it as it was to prevent confusion.

if(!empty($name) || !empty($email) || !empty($comment)){

	if(mail($to,"Comments From Your Site",$message,"From: $email\n")) { 

	echo "Your form was succsessful, write what you want here"; 
}

it simply checks if the fields are NOT empty, if they are not, the form will be send, else it will echo the error

[donkeymusic]

ah right i get you know

i will make the changes thanks

[donkeymusic]

i added those changes but the form still sends

[Av-]

well im clueless from here, because it really should NOT send... lol

[donkeymusic]

Here is what i have can you just check incase i missed something or added something i shouldnt have done

<? 

$name=$_POST['name']; 

$email=$_POST['email']; 

$comment=$_POST['question']; 

$to="enquiries@retrodesigner.co.uk"; 

$message=" $name sent you a comment on your site.\n They asked $question\n\n Their e-mail address was: $email"; 

if(!empty($name) || !empty($email) || !empty($comment)){

	if(mail($to,"Comments From Your Site",$message,"From: $email\n")) { 

	echo "Your form was succsessful, write what you want here"; 
}else { 

echo "Sorry, there was a problem with your question please try again."; 

} 

?>

[rc69]

Lol, i know what your problem is (and i'm laughing because i missed it on my first read through this ). The wrong operator was used in your if-statement. We want to make sure EVERYTHING is filled out, not one "or" the other thing

if(!empty($name) || !empty($email) || !empty($comment)){
// Needs to be
if(!empty($name) && !empty($email) && !empty($comment)){

Edited by rc69, 04 January 2006 - 04:44 PM.

[Av-]

lol yeah, my mistake

[donkeymusic]

thanks i will try that and make he changes

[donkeymusic]

I have just made the changes and tested and now it the form wont send and i get the following

Parse error: parse error in /home/httpd/vhosts/retrodesigner.co.uk/httpdocs/mail.php on line 24


which seems odd as there is no line 24.

Any Ideas?

cheers.

RESULT: after it not working i have just scrapped that file and started agin from the top of this post and although i am sure i just copied an pasted last time, this time when i have copied it it seems to work, so thanks for all your help guys much appreciated.

ARGH!!!!

now the form wont return to a webpage when form is sent.

here is my code, what is wrong? please

<? 

$name=$_POST['name']; 

$email=$_POST['email']; 

$comment=$_POST['question']; 

$to="Write you email address here, it will not be visible"; 

$message=" $name sent you a comment on your site.\n They said $story\n\n Their e-mail address was: $email"; 

if(!empty($name) && !empty($email) && !empty($question)){

	if(mail($to,"Comments From Your Site",$message,"From: $email\n")) { 

	header('location: index.html');
 
}
} else { 

header('location: contact.html');
 

} 

?>

Edited by donkeymusic, 06 January 2006 - 04:10 AM.

[Av-]

yeah they header function sometimes doesnt work for some reason....
try meta refresh instead

echo '<meta http-equiv="refresh" content="0;url=index.html">';
exit();