5 replies to this topic

[Ziggy]

i am tring to get the extension of a file and here is my code so far

function ext($file){
	$a = explode(".", $file);
	$b = count($a);
	$ext = $a[$b];
	return $ext;
}

the problem is that it wont output the extension!

Edited by Ziggy, 02 June 2007 - 12:23 PM.

[Matthew.]

You've missed something I myself have done before. Remember numeric arrays start with 0, not 1 as the value returned by count will do. Basically that means it is looking for an array element that does not exist.

All this means is we need to change this line:

$ext = $a[$b];

To this:

$ext = $a[($b - 1)];

You could also do:

return $a[count($a)-1];

Matt

Edited by Matthew., 02 June 2007 - 12:41 PM.

[Av-]

hmm, try this instead

function ext($file){
	$a = array_reverse(explode(".", $file));
	return $a[0];
}

Given that the extension is always at the end, if your reverse the array, it will be the first key

edit: Matt beat me to it

Edited by Av-, 02 June 2007 - 12:39 PM.

[rc69]

Or better yet, don't create a custom function, but use a built in one...

pathinfo().

[Matthew.]

rc69, on Jun 2 2007, 07:35 PM, said:

Or better yet, don't create a custom function, but use a built in one...

pathinfo().

Damn your book like knowledge. Thanks rc, didn't know about that.

[Ziggy]

thanks guys