8 replies to this topic

[Braunson]

Okay, Im trying to get this function working for my search for the forums.
Now I want it to highlight the word on the page...

My Code:

	$hlight = htmlspecialchars($_GET['highlight']);

function hlight($word){	   
	if($hlight){
		$word = eregi_replace($hlight, '<span style="color:#FFFF99;">' . $hlight . '</span>', $word);
	} else {
		$word = $word;
	}
	return $word;
}

Now i use it like so and all the variables are defined.
www.site.com/index.php?showtopic=1&highlight=testing

Now either way If i use it with or without &highlight=testing It still displays the regular text/content or $word without the highlighting.

Can anybody help. It's probably something stupid lol

[Demonslay]

Ok, two things.

1. You are trying to access a variable outside of the function's scope without globalizing the variable.
2. You aren't invoking the function.

This is more of how it should look. No use in using a eregi_* function when you aren't using regular expressions; preg_* functions are much faster anyways.

$content = 'Your content string.';
if(isset($_GET['highlight'])){
  $hlight = htmlspecialchars($_GET['highlight']);
  $content = str_replace($highlight, '<span style="color:#ff9;">'.$highlight.'</span>', $content);
}

[Braunson]

Hmm weird, I did that first, and it did nothing. hmm... That works now. I dont see what I did wrong.'

  $topicx = $topic['text'];
if(isset($_GET['highlight'])){
  $highlight = htmlspecialchars($_GET['highlight']);
  $topicx = str_replace($highlight, '<span style="color:#ff9;">'.$highlight.'</span>', $topicx);
}

Dosnt work >_>

Edited by Braunson, 17 August 2007 - 09:24 PM.

[Demonslay]

Explain 'doesnt work'. Is it simply not highlighting the text, or what?

I've tested the code with some dummy text and it works fine...

[Braunson]

Yes, it just returns the text. Sorry lol. It dosn't highlight or anything. Here's how im using it...

		$topics = mysql_query("SELECT * FROM `forum_threads` WHERE `id` = '".$id."'");
		if($topics)
		{
			$topic = mysql_fetch_array($topics);
			echo ("<br />
							<div style=\"background: #F8F8F8; padding: 5px;\" align=\"left\">");

 $topicx = $topic['text'];
if(isset($_GET['highlight'])){
  $highlight = htmlspecialchars($_GET['highlight']);
  $topicx = str_replace($highlight, '<span style="color:#ff9;">'.$highlight.'</span>', $topicx);
}
			echo("				</div>
			");
		   }

Thanks Demonslay!

[Demonslay]

You have to echo your text...

$topics = mysql_query("SELECT * FROM `forum_threads` WHERE `id` = {$id}") or die(mysql_error());
if(mysql_num_rows($topics) > 0){
  $topic = mysql_fetch_array($topics);
  echo '<br /><div style="background:#f8f8f8;padding:5px;" align="left">';
  $topicx = $topic['text'];
  if(isset($_GET['highlight'])){
	$highlight = htmlspecialchars($_GET['highlight']);
	$topicx = str_replace($highlight, '<span style="color:#ff9;">'.$highlight.'</span>', $topicx);
  }
  echo $topicx.'</div>';
}

[Braunson]

Hmm What am I doing wrong =\
Still dosn't work for me.

[Demonslay]

Check the source of the page and check that the text is indeed being wrapped by the span tags.
And for an actual 'highlight' you'd probably be better in setting a background color rather than a text color in the span's style.

[Braunson]

I have checked the source, it dosn't add the span at all. and Im going to add the background after I get it working. Thanks tho

Could something be possible conflicting with this, since what displays the topics from a form is inside a topic...